Hi Odin, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/sched/core] [also build test ERROR on tip/master linux/master linus/master v5.13-rc4 next-20210603] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Odin-Ugedal/sched-fair-Correctly-insert-cfs_rq-s-to-list-on-unthrottle/20210603-194311 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 858f9e11be8855ed62cb97e58174515da595c76b config: h8300-randconfig-r001-20210603 (attached as .config) compiler: h8300-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/fd98f41f84acfad0ad1c7d1eb553807e8d1e0b9b git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Odin-Ugedal/sched-fair-Correctly-insert-cfs_rq-s-to-list-on-unthrottle/20210603-194311 git checkout fd98f41f84acfad0ad1c7d1eb553807e8d1e0b9b # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): kernel/sched/fair.c: In function 'tg_unthrottle_up': >> kernel/sched/fair.c:4704:13: error: 'struct cfs_rq' has no member named 'tg_load_avg_contrib' 4704 | if (cfs_rq->tg_load_avg_contrib || cfs_rq->nr_running) | ^~ vim +4704 kernel/sched/fair.c 4689 4690 static int tg_unthrottle_up(struct task_group *tg, void *data) 4691 { 4692 struct rq *rq = data; 4693 struct cfs_rq *cfs_rq = tg->cfs_rq[cpu_of(rq)]; 4694 4695 cfs_rq->throttle_count--; 4696 if (!cfs_rq->throttle_count) { 4697 cfs_rq->throttled_clock_task_time += rq_clock_task(rq) - 4698 cfs_rq->throttled_clock_task; 4699 4700 /* 4701 * Add cfs_rq with tg load avg contribution or one or more 4702 * already running entities to the list 4703 */ > 4704 if (cfs_rq->tg_load_avg_contrib || cfs_rq->nr_running) 4705 list_add_leaf_cfs_rq(cfs_rq); 4706 } 4707 4708 return 0; 4709 } 4710 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
