On Fri 23-04-21 06:13:30, Vasily Averin wrote: > On 4/22/21 3:26 PM, Borislav Petkov wrote: > > On Thu, Apr 22, 2021 at 01:38:01PM +0300, Vasily Averin wrote: > > > > You have forgotten to Cc LKML on your submission. > I think it's OK, patch set is addressed to cgroups subsystem amiling list. > Am I missed something and such patches should be sent to LKML anyway? Yes, it is preferable to CC all patches to lkml. These patches are not cgroup specit much. A specific subsystem knowledge is require to judge them and most people are not subscribed to the cgroup ML. > >> @@ -168,9 +168,10 @@ static struct ldt_struct *alloc_ldt_struct(unsigned int num_entries) > >> * than PAGE_SIZE. > >> */ > >> if (alloc_size > PAGE_SIZE) > >> - new_ldt->entries = vzalloc(alloc_size); > >> + new_ldt->entries = __vmalloc(alloc_size, > >> + GFP_KERNEL_ACCOUNT | __GFP_ZERO); > > > > You don't have to break that line - just let it stick out. > Hmm. I missed that allowed line limit was increased up to 100 bytes, > Thank you, I will fix it in next patch version. Line limits are more of a guidance than a hard rule. Also please note that different subsystems' maintainers insist on this guidance differently. -- Michal Hocko SUSE Labs
