Re: [cgroup:for-next 3/3] include/linux/misc_cgroup.h:98:15: warning: no previous prototype for function 'misc_cg_res_total_usage'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 4, 2021 at 3:32 PM Tejun Heo <tj@xxxxxxxxxx> wrote:
>
> Applied the following patch to cgroup/for-5.13.
>
> Thanks.
> ----- 8< -----
> From dd3f4e4972f146a685930ccfed95e4e1d13d952a Mon Sep 17 00:00:00 2001
> From: Tejun Heo <tj@xxxxxxxxxx>
> Date: Sun, 4 Apr 2021 18:29:37 -0400
> Subject: [PATCH] cgroup: misc: mark dummy misc_cg_res_total_usage() static
>  inline
>
> The dummy implementation was missing static inline triggering the following
> compile warning on llvm.
>
>    In file included from arch/x86/kvm/svm/sev.c:17:
> >> include/linux/misc_cgroup.h:98:15: warning: no previous prototype for function 'misc_cg_res_total_usage' [-Wmissing-prototypes]
>    unsigned long misc_cg_res_total_usage(enum misc_res_type type)
>                  ^
>    include/linux/misc_cgroup.h:98:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    unsigned long misc_cg_res_total_usage(enum misc_res_type type)
>    ^
>    static
>    1 warning generated.
>
> Add it.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> ---
>  include/linux/misc_cgroup.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/misc_cgroup.h b/include/linux/misc_cgroup.h
> index c5af592481c0..da2367e2ac1e 100644
> --- a/include/linux/misc_cgroup.h
> +++ b/include/linux/misc_cgroup.h
> @@ -95,7 +95,7 @@ static inline void put_misc_cg(struct misc_cg *cg)
>
>  #else /* !CONFIG_CGROUP_MISC */
>
> -unsigned long misc_cg_res_total_usage(enum misc_res_type type)
> +static inline unsigned long misc_cg_res_total_usage(enum misc_res_type type)
>  {
>         return 0;
>  }
> --
> 2.31.1
>

Thanks for the quick patch Tejun. Sorry about the issue.



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux