On Mon, 15 Mar 2021 12:32:07 -0700 Roman Gushchin wrote: > On Mon, Mar 15, 2021 at 12:24:31PM -0700, Shakeel Butt wrote: > > On Mon, Mar 15, 2021 at 10:09 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > > Sorry for a random question, I didn't get the cover letter. > > > > > > What's the overhead of adding SLAB_ACCOUNT? > > > > The potential overhead is for MEMCG users where we need to > > charge/account each allocation from SLAB_ACCOUNT kmem caches. However > > charging is done in batches, so the cost is amortized. If there is a > > concern about a specific workload then it would be good to see the > > impact of this patch for that workload. > > > > > Please make sure you CC netdev on series which may impact networking. > > In general the overhead is not that big, so I don't think we should argue > too much about every new case where we want to enable the accounting and > rather focus on those few examples (if any?) where it actually hurts > the performance in a meaningful way. Ack, no serious concerns about this particular case. I was expecting you'd have micro benchmark numbers handy so I was curious to learn what they are, but that appears not to be the case.
