On Thu, Oct 29, 2020 at 2:08 AM Michal Hocko <mhocko@xxxxxxxx> wrote: > > On Wed 28-10-20 11:50:13, Muchun Song wrote: > [...] > > -struct lruvec *mem_cgroup_page_lruvec(struct page *page, struct pglist_data *pgdat) > > +static struct lruvec * > > +__mem_cgroup_node_lruvec(struct mem_cgroup *memcg, struct pglist_data *pgdat, > > + int nid) > > I thought I have made it clear that this is not a good approach. Please > do not repost new version without that being addressed. If there are any > questions then feel free to ask for details. You can get nid from pgdat (pgdat->node_id) and also pgdat from nid (NODE_DATA(nid)), so, __mem_cgroup_node_lruvec() only need one of them as parameter.
