On 2020/10/26 21:47, Tejun Heo wrote: > On Mon, Oct 12, 2020 at 06:27:57PM +0800, Chen Zhou wrote: >> When mounting a cgroup hierarchy with disabled controller in cgroup v1, >> all available controllers will be attached. >> >> Add disabled controller check in cgroup1_parse_param() and return directly >> if the specified controller is disabled. >> >> Signed-off-by: Chen Zhou <chenzhou10@xxxxxxxxxx> > check_cgroupfs_options() is already checking the condition. How does also > checking in parse_param() help? Hi Tejun, Function check_cgroupfs_options() don't check if the mounted controller is disabled. It just gets the enabled controllers firstly, and then do & opteration with the mounted controller. If the result is NULL, just select all the enabled controllers. This patch check if the specified controller of mount is disabled, and return "Disabled controller xx" error if true. Thanks, Chen Zhou > > Thanks. >
