On Tue, 19 May 2020 15:15:41 -0700 Shakeel Butt wrote: > > --- a/mm/page_counter.c > > +++ b/mm/page_counter.c > > @@ -198,6 +198,11 @@ int page_counter_set_max(struct page_counter *counter, unsigned long nr_pages) > > } > > } > > > > +void page_counter_set_high(struct page_counter *counter, unsigned long nr_pages) > > +{ > > + WRITE_ONCE(counter->high, nr_pages); > > +} > > + > > Any reason not to make this static inline like > page_counter_is_above_high() and in page_counter.h? My reason was consistency with other page_counter_set_xyz() helpers, but obviously happy to change if needed...