On Tue, Mar 10, 2020 at 1:40 PM Daniel Xu <dxu@xxxxxxxxx> wrote: > > Hi Shakeel, > > On Tue Mar 10, 2020 at 12:40 PM, Shakeel Butt wrote: > > Hi Daniel, > > > > > > On Thu, Mar 5, 2020 at 1:16 PM Daniel Xu <dxu@xxxxxxxxx> wrote: > > > > > > It's not really necessary to have contiguous physical memory for xattr > > > values. We no longer need to worry about higher order allocations > > > failing with kvmalloc, especially because the xattr size limit is at > > > 64K. > > > > > > Signed-off-by: Daniel Xu <dxu@xxxxxxxxx> > > > > > > The patch looks fine to me. However the commit message is too cryptic > > i.e. hard to get the motivation behind the change. > > > > Thanks for taking a look. The real reason I did it was because Tejun > said so :). > > Tejun, is there a larger reason? > I understand the reason. I am just suggesting to rephrase it to be more clear.