On Wed, Jan 29, 2020 at 03:22:55PM +0100, Michal Koutný wrote: > Hello. > > On Sat, Jan 18, 2020 at 08:40:51AM +0530, madhuparnabhowmik10@xxxxxxxxx wrote: > > From: Madhuparna Bhowmik <madhuparnabhowmik10@xxxxxxxxx> > > > > list_for_each_entry_rcu has built-in RCU and lock checking. > > Pass cond argument to list_for_each_entry_rcu() to silence > > false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled > > by default. > I assume if you've seen the RCU warning, you haven't seen the warning > from cgroup_assert_mutex_or_rcu_locked() above. > No, I haven't seen any warning from cgroup_assert_mutex_or_rcu_locked(), I am just doing the conversions to prevent any false lockdep warnings because of CONFIG_PROVE_RCU_LIST in the future. > The patch makes sense to me from the consistency POV. > Thank you, Madhuparna > Acked-by: Michal Koutný <mkoutny@xxxxxxxx> > > Michal