On Tue, Jan 21, 2020 at 04:48:41PM +0100, Christian Brauner <christian.brauner@xxxxxxxxxx> wrote: > diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c > index 9b3241d67592..ce2d5b8aa19f 100644 > --- a/kernel/cgroup/cgroup.c > +++ b/kernel/cgroup/cgroup.c > @@ -5895,17 +5895,21 @@ static struct cgroup *cgroup_get_from_file(struct file *f) > > /** > * cgroup_can_fork - called on a new task before the process is exposed > - * @child: the task in question. > + * @child: the child process > + * @kargs: the arguments passed to create the child process This comment should only come with the later commmits. > - * cgroup_cancel_fork - called if a fork failed after cgroup_can_fork() > - * @child: the task in question > - * > - * This calls the cancel_fork() callbacks if a fork failed *after* > - * cgroup_can_fork() succeded. > - */ > + * cgroup_cancel_fork - called if a fork failed after cgroup_can_fork() > + * @child: the child process > + * @kargs: the arguments passed to create the child process Ditto > - * cgroup_post_fork - called on a new task after adding it to the task list > - * @child: the task in question > - * > - * Adds the task to the list running through its css_set if necessary and > - * call the subsystem fork() callbacks. Has to be after the task is > - * visible on the task list in case we race with the first call to > - * cgroup_task_iter_start() - to guarantee that the new task ends up on its > - * list. > + * cgroup_post_fork - finalize cgroup setup for the child process > + * @child: the child process > + * @kargs: the arguments passed to create the child process One more. Besides the misrebased comments Acked-by: Michal Koutný <mkoutny@xxxxxxxx>
