On Tue, Jan 21, 2020 at 04:48:39PM +0100, Christian Brauner <christian.brauner@xxxxxxxxxx> wrote: > +static int cgroup_attach_permissions(struct cgroup *src_cgrp, > + struct cgroup *dst_cgrp, > + struct super_block *sb, bool thread) I suggest inverting the logic of the last argument to make it consistent with other functions that use threadgroup argument for similar distinction. Apart from that Acked-by: Michal Koutný <mkoutny@xxxxxxxx>
