Mike Kravetz <mike.kravetz@xxxxxxxxxx> writes: > On 12/12/19 11:41 AM, Johannes Weiner wrote: >> [CC Andrew] >> >> Andrew, can you pick up this patch please? >> >> On Thu, Dec 05, 2019 at 12:47:39PM +0100, Giuseppe Scrivano wrote: >>> In the effort of supporting cgroups v2 into Kubernetes, I stumped on >>> the lack of the hugetlb controller. >>> >>> When the controller is enabled, it exposes three new files for each > > Nit, there are four files now that you added "events.local" > >>> hugetlb size on non-root cgroups: >>> >>> - hugetlb.<hugepagesize>.current >>> - hugetlb.<hugepagesize>.max >>> - hugetlb.<hugepagesize>.events >>> - hugetlb.<hugepagesize>.events.local >>> >>> The differences with the legacy hierarchy are in the file names and >>> using the value "max" instead of "-1" to disable a limit. >>> >>> The file .limit_in_bytes is renamed to .max. >>> >>> The file .usage_in_bytes is renamed to .usage. >> >> Minor point: that should be ".current" rather than ".usage" >> >>> .failcnt is not provided as a single file anymore, but its value can >>> be read through the new flat-keyed files .events and .events.local, >>> through the "max" key. >>> >>> Signed-off-by: Giuseppe Scrivano <gscrivan@xxxxxxxxxx> >> >> Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx> > > Since this has no impacts on core hugetlb code, and appears to do what is > needed for cgroups v2, you can add: > > Acked-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx> thanks for the reviews, I've fixed the commit message and sent the updated version. Giuseppe
