chengkaitao writes:
Subject: Re: [PATCH v2] mm: cleanup some useless code
Can you please write a more descriptive commit title? Seeing this in the commit
history tells the reader nothing, "code" could mean anything from a state
machine to a boolean, and "cleanup" could mean anything from some complex
refactoring to something trivial like this, and right now I have to look and
see the individual commit. This patch is really just deduplication of effort.
Perhaps:
mm, memcg: Don't check PageTransHuge before calling hpage_nr_pages
It is much simpler to just use hpage_nr_pages for nr_pages and replace
the local variable by PageTransHuge check directly
Heh, calling it "much" simpler seems a bit excessive. I mean, the code is just
as readable in both cases, but if it's going to go in, then that's fine. Any
merge conflict should be trivial enough to fix.
Signed-off-by: Kaitao Cheng <pilgrimtao@xxxxxxxxx>
Acked-by: Michal Hocko <mhocko@xxxxxxxx>
I'm indifferent to this patch, but after the title change:
Acked-by: Chris Down <chris@xxxxxxxxxxxxxx>
