Mina Almasry <almasrymina@xxxxxxxxxx> writes: >> Mina has been working/pushing the effort to add reservations to cgroup >> accounting and would be the one to ask. However, it does seem that the >> names here should be created in anticipation of adding reservations in >> the future. So, perhaps something like: >> >> hugetlb_usage.<hugepagesize>.current >> >> with the new functionality having names like >> >> hugetlb_reserves.<hugepagesize>.current > > I was thinking I'll just rebase my patches on top of this patch and > add the files for the reservations myself, since Guiseppe doesn't have > an implementation of that locally so the files would be dummies (or > maybe they would mirror the current counters). > > But if Guiseppe is adding them then that's fine too. I would prefer names: > > hugetlb.<hugepagesize>.current_reservations > hugetlb.<hugepagesize>.max_reservations I think it is better to add them as part of the patch that is also adding the functionality. I've fixed the issue with events and events.local Michal reported, now it works similarly to the memcg. I'll send the updated version once we agree on the file names to use. Are you fine if I keep these two file names? - hugetlb.<hugepagesize>.current - hugetlb.<hugepagesize>.max Regards, Giuseppe
