Re: [PATCH v2] mm: hugetlb controller for cgroups v2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Tue, Nov 26, 2019 at 08:56:00PM +0100, Giuseppe Scrivano wrote:
> In the effort of supporting cgroups v2 into Kubernetes, I stumped on
> the lack of the hugetlb controller.
> 
> When the controller is enabled, it exposes three new files for each
> hugetlb size on non-root cgroups:
> 
> - hugetlb.<hugepagesize>.current
> - hugetlb.<hugepagesize>.max
> - hugetlb.<hugepagesize>.events
> 
> The differences with the legacy hierarchy are in the file names and
> using the value "max" instead of "-1" to disable a limit.
> 
> The file .limit_in_bytes is renamed to .max.
> 
> The file .usage_in_bytes is renamed to .usage.
> 
> .failcnt is not provided as a single file anymore, but its value can
> be read in the new flat-keyed file .events, through the "max" key.

Looks great.  Just one more thin.  The .events are expected to
generate file changed event when something changes inside so that
userspace can poll for it.  Can you please implement that for hugetlb
too?

Thanks.

-- 
tejun



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux