[cgroup:review-blkcg-rstat 2/6] block/bfq-cgroup.c:1245:15: error: 'bfqg_print_rwstat' undeclared here (not in a function); did you mean 'blkg_prfill_rwstat'?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-blkcg-rstat
head:   f86f96284bcfa2446930adb116ee42788e43a571
commit: ca1d91e70679511777232393542c36736f74ec03 [2/6] bfq-iosched: stop using blkg->stat_bytes and ->stat_ios
config: s390-debug_defconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout ca1d91e70679511777232393542c36736f74ec03
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> block/bfq-cgroup.c:1245:15: error: 'bfqg_print_rwstat' undeclared here (not in a function); did you mean 'blkg_prfill_rwstat'?
      .seq_show = bfqg_print_rwstat,
                  ^~~~~~~~~~~~~~~~~
                  blkg_prfill_rwstat
   block/bfq-cgroup.c:1288:15: error: 'bfqg_print_rwstat_recursive' undeclared here (not in a function); did you mean 'blkg_print_stat_ios_recursive'?
      .seq_show = bfqg_print_rwstat_recursive,
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
                  blkg_print_stat_ios_recursive

vim +1245 block/bfq-cgroup.c

  1226	
  1227	struct cftype bfq_blkcg_legacy_files[] = {
  1228		{
  1229			.name = "bfq.weight",
  1230			.flags = CFTYPE_NOT_ON_ROOT,
  1231			.seq_show = bfq_io_show_weight_legacy,
  1232			.write_u64 = bfq_io_set_weight_legacy,
  1233		},
  1234		{
  1235			.name = "bfq.weight_device",
  1236			.flags = CFTYPE_NOT_ON_ROOT,
  1237			.seq_show = bfq_io_show_weight,
  1238			.write = bfq_io_set_weight,
  1239		},
  1240	
  1241		/* statistics, covers only the tasks in the bfqg */
  1242		{
  1243			.name = "bfq.io_service_bytes",
  1244			.private = offsetof(struct bfq_group, stats.bytes),
> 1245			.seq_show = bfqg_print_rwstat,
  1246		},
  1247		{
  1248			.name = "bfq.io_serviced",
  1249			.private = offsetof(struct bfq_group, stats.ios),
  1250			.seq_show = bfqg_print_rwstat,
  1251		},
  1252	#ifdef CONFIG_BFQ_CGROUP_DEBUG
  1253		{
  1254			.name = "bfq.time",
  1255			.private = offsetof(struct bfq_group, stats.time),
  1256			.seq_show = bfqg_print_stat,
  1257		},
  1258		{
  1259			.name = "bfq.sectors",
  1260			.seq_show = bfqg_print_stat_sectors,
  1261		},
  1262		{
  1263			.name = "bfq.io_service_time",
  1264			.private = offsetof(struct bfq_group, stats.service_time),
  1265			.seq_show = bfqg_print_rwstat,
  1266		},
  1267		{
  1268			.name = "bfq.io_wait_time",
  1269			.private = offsetof(struct bfq_group, stats.wait_time),
  1270			.seq_show = bfqg_print_rwstat,
  1271		},
  1272		{
  1273			.name = "bfq.io_merged",
  1274			.private = offsetof(struct bfq_group, stats.merged),
  1275			.seq_show = bfqg_print_rwstat,
  1276		},
  1277		{
  1278			.name = "bfq.io_queued",
  1279			.private = offsetof(struct bfq_group, stats.queued),
  1280			.seq_show = bfqg_print_rwstat,
  1281		},
  1282	#endif /* CONFIG_BFQ_CGROUP_DEBUG */
  1283	
  1284		/* the same statistics which cover the bfqg and its descendants */
  1285		{
  1286			.name = "bfq.io_service_bytes_recursive",
  1287			.private = offsetof(struct bfq_group, stats.bytes),
  1288			.seq_show = bfqg_print_rwstat_recursive,
  1289		},
  1290		{
  1291			.name = "bfq.io_serviced_recursive",
  1292			.private = offsetof(struct bfq_group, stats.ios),
  1293			.seq_show = bfqg_print_rwstat_recursive,
  1294		},
  1295	#ifdef CONFIG_BFQ_CGROUP_DEBUG
  1296		{
  1297			.name = "bfq.time_recursive",
  1298			.private = offsetof(struct bfq_group, stats.time),
  1299			.seq_show = bfqg_print_stat_recursive,
  1300		},
  1301		{
  1302			.name = "bfq.sectors_recursive",
  1303			.seq_show = bfqg_print_stat_sectors_recursive,
  1304		},
  1305		{
  1306			.name = "bfq.io_service_time_recursive",
  1307			.private = offsetof(struct bfq_group, stats.service_time),
  1308			.seq_show = bfqg_print_rwstat_recursive,
  1309		},
  1310		{
  1311			.name = "bfq.io_wait_time_recursive",
  1312			.private = offsetof(struct bfq_group, stats.wait_time),
  1313			.seq_show = bfqg_print_rwstat_recursive,
  1314		},
  1315		{
  1316			.name = "bfq.io_merged_recursive",
  1317			.private = offsetof(struct bfq_group, stats.merged),
  1318			.seq_show = bfqg_print_rwstat_recursive,
  1319		},
  1320		{
  1321			.name = "bfq.io_queued_recursive",
  1322			.private = offsetof(struct bfq_group, stats.queued),
  1323			.seq_show = bfqg_print_rwstat_recursive,
  1324		},
  1325		{
  1326			.name = "bfq.avg_queue_size",
  1327			.seq_show = bfqg_print_avg_queue_size,
  1328		},
  1329		{
  1330			.name = "bfq.group_wait_time",
  1331			.private = offsetof(struct bfq_group, stats.group_wait_time),
  1332			.seq_show = bfqg_print_stat,
  1333		},
  1334		{
  1335			.name = "bfq.idle_time",
  1336			.private = offsetof(struct bfq_group, stats.idle_time),
  1337			.seq_show = bfqg_print_stat,
  1338		},
  1339		{
  1340			.name = "bfq.empty_time",
  1341			.private = offsetof(struct bfq_group, stats.empty_time),
  1342			.seq_show = bfqg_print_stat,
  1343		},
  1344		{
  1345			.name = "bfq.dequeue",
  1346			.private = offsetof(struct bfq_group, stats.dequeue),
  1347			.seq_show = bfqg_print_stat,
  1348		},
  1349	#endif	/* CONFIG_BFQ_CGROUP_DEBUG */
  1350		{ }	/* terminate */
  1351	};
  1352	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux