Re: [PATCH] cgroup: freezer: don't change task and cgroups status unnecessarily

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Roman Gushchin <guro@xxxxxx>
Subject: Re: [PATCH] cgroup: freezer: don't change task and cgroups status unnecessarily
From: Oleg Nesterov <oleg@xxxxxxxxxx>
Date: Thu, 24 Oct 2019 17:29:09 +0200
Cc: Honglei Wang <honglei.wang@xxxxxxxxxx>, "tj@xxxxxxxxxx" <tj@xxxxxxxxxx>, "lizefan@xxxxxxxxxx" <lizefan@xxxxxxxxxx>, "hannes@xxxxxxxxxxx" <hannes@xxxxxxxxxxx>, "cgroups@xxxxxxxxxxxxxxx" <cgroups@xxxxxxxxxxxxxxx>
In-reply-to: <20191023162011.GA27766@tower.DHCP.thefacebook.com>
References: <20191021081826.8769-1-honglei.wang@oracle.com> <20191022134555.GA5307@redhat.com> <20191022173113.GD21381@tower.DHCP.thefacebook.com> <20191023132350.GB14327@redhat.com> <20191023162011.GA27766@tower.DHCP.thefacebook.com>
User-agent: Mutt/1.5.24 (2015-08-30)

On 10/23, Roman Gushchin wrote:
>
> On Wed, Oct 23, 2019 at 03:23:50PM +0200, Oleg Nesterov wrote:
> >
> > Not sure I understand... The patch doesn't remove cgroup_freeze_task(),
> > it shifts it up, under the test_bit(CGRP_FREEZE, &dst).
>
> Yes, but it does remove cgroup_freeze_task(task, false) if the target
> cgroup is not frozen.

Ah, got it.

Right you are, thanks for correcting me!

Oleg.

References:
- [PATCH] cgroup: freezer: don't change task and cgroups status unnecessarily
  - From: Honglei Wang
- Re: [PATCH] cgroup: freezer: don't change task and cgroups status unnecessarily
  - From: Oleg Nesterov
- Re: [PATCH] cgroup: freezer: don't change task and cgroups status unnecessarily
  - From: Roman Gushchin
- Re: [PATCH] cgroup: freezer: don't change task and cgroups status unnecessarily
  - From: Oleg Nesterov
- Re: [PATCH] cgroup: freezer: don't change task and cgroups status unnecessarily
  - From: Roman Gushchin

Prev by Date: Re: [PATCH 2/2] mm: memcontrol: try harder to set a new memory.high
Next by Date: Re: [PATCH v4 1/2] sched/topology: Don't try to build empty sched domains
Previous by thread: Re: [PATCH] cgroup: freezer: don't change task and cgroups status unnecessarily
Next by thread: [PATCH 0/8]: mm: vmscan: cgroup-related cleanups
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API] [Monitors]