Hello, Michal. On Fri, Jun 07, 2019 at 07:09:53PM +0200, Michal Koutný wrote: > Wouldn't it make more sense to call > css_set_move_task(tsk, cset, NULL, false); > in cgroup_release instead of cgroup_exit then? > > css_set_move_task triggers the cgroup emptiness notification so if we > list group leaders with running siblings as members of the cgroup (IMO > correct), is it consistent to deliver the (un)populated event > that early? > By moving to cgroup_release we would also make this notification > analogous to SIGCHLD delivery. So, the current behavior is mostly historical and I don't think this is a better behavior. That said, I'm not sure about the cost benefit ratio of changing the behavior at this point given how long the code has been this way. Another aspect is that it'd expose zombie tasks and possibly migrations of them to each controller. Thanks. -- tejun
