On Thu, May 23, 2019 at 04:09:30PM -0700, Yonghong Song wrote: > > > On 5/23/19 12:45 PM, Roman Gushchin wrote: > > Add a kselftest to cover bpf auto-detachment functionality. > > The test creates a cgroup, associates some resources with it, > > attaches a couple of bpf programs and deletes the cgroup. > > > > Then it checks that bpf programs are going away in 5 seconds. > > > > Expected output: > > $ ./test_cgroup_attach > > #override:PASS > > #multi:PASS > > #autodetach:PASS > > test_cgroup_attach:PASS > > > > On a kernel without auto-detaching: > > $ ./test_cgroup_attach > > #override:PASS > > #multi:PASS > > #autodetach:FAIL > > test_cgroup_attach:FAIL > > > > Signed-off-by: Roman Gushchin <guro@xxxxxx> > > Looks good to me. It will be good if you can add test_cgroup_attach > to .gitignore to avoid it shows up in `git status`. With that, > Here it is! Thanks! --- >From 150fb4db7ab37f0e8b6482386e8830f3d11b64e1 Mon Sep 17 00:00:00 2001 From: Roman Gushchin <guro@xxxxxx> Date: Thu, 23 May 2019 16:46:58 -0700 Subject: [PATCH bpf-next] selftests/bpf: add test_cgroup_attach to .gitignore Add test_cgroup_attach binary to .gitignore. Signed-off-by: Roman Gushchin <guro@xxxxxx> --- tools/testing/selftests/bpf/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore index dd5d69529382..86a546e5e4db 100644 --- a/tools/testing/selftests/bpf/.gitignore +++ b/tools/testing/selftests/bpf/.gitignore @@ -22,6 +22,7 @@ test_lirc_mode2_user get_cgroup_id_user test_skb_cgroup_id_user test_socket_cookie +test_cgroup_attach test_cgroup_storage test_select_reuseport test_flow_dissector -- 2.20.1