On Thu, May 16, 2019 at 10:15 AM Roman Gushchin <guro@xxxxxx> wrote: > > On Thu, May 16, 2019 at 05:31:44PM +0200, Pavel Hrdina wrote: > > On Thu, May 16, 2019 at 03:22:33PM +0000, Roman Gushchin wrote: > > > On Thu, May 16, 2019 at 12:39:15PM +0200, Jiri Olsa wrote: > > > > hi, > > > > Pavel reported an issue with bpf programs (attached to cgroup) > > > > not being released at the time when the cgroup is removed and > > > > are still visible in 'bpftool prog' list afterwards. > > > > > > Hi Jiri! > > > > > > Can you, please, try the patch from > > > https://github.com/rgushchin/linux/commit/f77afa1952d81a1afa6c4872d342bf6721e148e2 ? > > > > > > It should solve the problem, and I'm about to post it upstream. > > > > Perfect, I'll give it a try with full libvirt setup as well. > > > > Can we have this somehow detectable from user-space so libvirt can > > decide when to use BPF or not? I would like to avoid using BPF with > > libvirt if this issue is not fixed and we cannot simply workaround it > > as systemd automatically removes cgroups for us. > > Hm, I don't think there is a good way to detect it from userspace. > At least I have no good ideas. Alexei? Daniel? > > If you're interested in a particular stable version, we can probably > treat it as a "fix", and backport. right. also user space workaround is trivial. Just detach before rmdir.