Re: [PATCH -next] cgroup: Remove unused cgrp variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 30, 2019 at 12:37:58PM +0000, Roman Gushchin wrote:
> On Tue, Apr 30, 2019 at 05:57:29PM +0800, Shaokun Zhang wrote:
> > The 'cgrp' is set but not used in commit <76f969e8948d8>
> > ("cgroup: cgroup v2 freezer").
> > Remove it to avoid [-Wunused-but-set-variable] warning.
> > 
> > Cc: Roman Gushchin <guro@xxxxxx>
> > Cc: Tejun Heo <tj@xxxxxxxxxx>
> > Signed-off-by: Shaokun Zhang <zhangshaokun@xxxxxxxxxxxxx>
> 
> Hi Shaokun!
> 
> There is a cgroup_update_frozen(cgrp) call just below,
> so the variable is in use.

Ah, I'm sorry, I did look at the old version. The call I mention
has been removed in the latest one, so you're right, the variable
isn't used anymore.

Acked-by: Roman Gushchin <guro@xxxxxx>

Thank you!




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux