On Wed, Apr 10, 2019 at 1:55 AM Johannes Weiner <hannes@xxxxxxxxxxx> wrote: > > On Tue, Apr 09, 2019 at 09:13:43PM +0800, Yafang Shao wrote: > > Now we count PGSCAN_KSWAPD and PGSCAN_DIRECT into one single item > > 'pgscan', that's not proper. > > > > PGSCAN_DIRECT is triggered by the tasks in this memcg, which directly > > indicates the memory status of this memcg; > > PGSCAN_DIRECT occurs independent of cgroups when kswapd is overwhelmed > or when allocations don't pass __GFP_KSWAPD_RECLAIM. You'll get direct > reclaim inside memcgs that don't have a limit. Oh yes. Plus PGSCAN_DIRECT may also triggered by the tasks in the parent memcg. 'pgscan' here only cares about the memory in this memcg, other than the tasks in this memcg. Seems we'd better introduce another counter to reflect the tasks in this memcg. Thanks Yafang
