Re: [PATCH v4 5/5] kernfs: initialize security of newly created nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ondrej,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on driver-core/driver-core-testing]
[also build test WARNING on v5.0-rc4 next-20190205]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ondrej-Mosnacek/Allow-initializing-the-kernfs-node-s-secctx-based-on-its-parent/20190205-171434
config: x86_64-randconfig-x013-201905 (attached as .config)
compiler: gcc-8 (Debian 8.2.0-14) 8.2.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from fs/kernfs/dir.c:16:
   include/linux/security.h:796:1: error: expected identifier or '(' before '{' token
    {
    ^
>> include/linux/security.h:792:19: warning: 'security_kernfs_init_security' used but never defined
    static inline int security_kernfs_init_security(
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/security_kernfs_init_security +792 include/linux/security.h

d8ad8b49 Vivek Goyal     2016-07-13  791  
42221e5e Ondrej Mosnacek 2019-02-05 @792  static inline int security_kernfs_init_security(
42221e5e Ondrej Mosnacek 2019-02-05  793  		const struct qstr *qstr, const struct iattr *dir_iattr,
42221e5e Ondrej Mosnacek 2019-02-05  794  		struct simple_xattrs *dir_secattr, const struct iattr *iattr,
42221e5e Ondrej Mosnacek 2019-02-05  795  		struct simple_xattrs *secattr);
42221e5e Ondrej Mosnacek 2019-02-05 @796  {
42221e5e Ondrej Mosnacek 2019-02-05  797  	return 0;
42221e5e Ondrej Mosnacek 2019-02-05  798  }
42221e5e Ondrej Mosnacek 2019-02-05  799  

:::::: The code at line 792 was first introduced by commit
:::::: 42221e5e86c5c3352de02eeb388cef953cdde4a0 LSM: add new hook for kernfs node initialization

:::::: TO: Ondrej Mosnacek <omosnace@xxxxxxxxxx>
:::::: CC: 0day robot <lkp@xxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux