Re: [PATCH 1/5] Memcgroup: force empty after memcgroup offline

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Xiongchun,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.0-rc2 next-20190116]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Xiongchun-Duan/Memcgroup-force-empty-after-memcgroup-offline/20190122-014721
config: i386-randconfig-s2-01210338 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

>> kernel/sysctl.c:1257:22: error: 'sysctl_cgroup_default_retry' undeclared here (not in a function)
      .data           = &sysctl_cgroup_default_retry,
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/sysctl.c:1261:22: error: 'sysctl_cgroup_default_retry_min' undeclared here (not in a function)
      .extra1         = &sysctl_cgroup_default_retry_min,
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/sysctl.c:1262:22: error: 'sysctl_cgroup_default_retry_max' undeclared here (not in a function)
      .extra2         = &sysctl_cgroup_default_retry_max,
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/sysctl_cgroup_default_retry +1257 kernel/sysctl.c

   977	
   978	#if defined(CONFIG_X86_LOCAL_APIC) && defined(CONFIG_X86)
   979		{
   980			.procname       = "unknown_nmi_panic",
   981			.data           = &unknown_nmi_panic,
   982			.maxlen         = sizeof (int),
   983			.mode           = 0644,
   984			.proc_handler   = proc_dointvec,
   985		},
   986	#endif
   987	#if defined(CONFIG_X86)
   988		{
   989			.procname	= "panic_on_unrecovered_nmi",
   990			.data		= &panic_on_unrecovered_nmi,
   991			.maxlen		= sizeof(int),
   992			.mode		= 0644,
   993			.proc_handler	= proc_dointvec,
   994		},
   995		{
   996			.procname	= "panic_on_io_nmi",
   997			.data		= &panic_on_io_nmi,
   998			.maxlen		= sizeof(int),
   999			.mode		= 0644,
  1000			.proc_handler	= proc_dointvec,
  1001		},
  1002	#ifdef CONFIG_DEBUG_STACKOVERFLOW
  1003		{
  1004			.procname	= "panic_on_stackoverflow",
  1005			.data		= &sysctl_panic_on_stackoverflow,
  1006			.maxlen		= sizeof(int),
  1007			.mode		= 0644,
  1008			.proc_handler	= proc_dointvec,
  1009		},
  1010	#endif
  1011		{
  1012			.procname	= "bootloader_type",
  1013			.data		= &bootloader_type,
  1014			.maxlen		= sizeof (int),
  1015			.mode		= 0444,
  1016			.proc_handler	= proc_dointvec,
  1017		},
  1018		{
  1019			.procname	= "bootloader_version",
  1020			.data		= &bootloader_version,
  1021			.maxlen		= sizeof (int),
  1022			.mode		= 0444,
  1023			.proc_handler	= proc_dointvec,
  1024		},
  1025		{
  1026			.procname	= "io_delay_type",
  1027			.data		= &io_delay_type,
  1028			.maxlen		= sizeof(int),
  1029			.mode		= 0644,
  1030			.proc_handler	= proc_dointvec,
  1031		},
  1032	#endif
  1033	#if defined(CONFIG_MMU)
  1034		{
  1035			.procname	= "randomize_va_space",
  1036			.data		= &randomize_va_space,
  1037			.maxlen		= sizeof(int),
  1038			.mode		= 0644,
  1039			.proc_handler	= proc_dointvec,
  1040		},
  1041	#endif
  1042	#if defined(CONFIG_S390) && defined(CONFIG_SMP)
  1043		{
  1044			.procname	= "spin_retry",
  1045			.data		= &spin_retry,
  1046			.maxlen		= sizeof (int),
  1047			.mode		= 0644,
  1048			.proc_handler	= proc_dointvec,
  1049		},
  1050	#endif
  1051	#if	defined(CONFIG_ACPI_SLEEP) && defined(CONFIG_X86)
  1052		{
  1053			.procname	= "acpi_video_flags",
  1054			.data		= &acpi_realmode_flags,
  1055			.maxlen		= sizeof (unsigned long),
  1056			.mode		= 0644,
  1057			.proc_handler	= proc_doulongvec_minmax,
  1058		},
  1059	#endif
  1060	#ifdef CONFIG_SYSCTL_ARCH_UNALIGN_NO_WARN
  1061		{
  1062			.procname	= "ignore-unaligned-usertrap",
  1063			.data		= &no_unaligned_warning,
  1064			.maxlen		= sizeof (int),
  1065		 	.mode		= 0644,
  1066			.proc_handler	= proc_dointvec,
  1067		},
  1068	#endif
  1069	#ifdef CONFIG_IA64
  1070		{
  1071			.procname	= "unaligned-dump-stack",
  1072			.data		= &unaligned_dump_stack,
  1073			.maxlen		= sizeof (int),
  1074			.mode		= 0644,
  1075			.proc_handler	= proc_dointvec,
  1076		},
  1077	#endif
  1078	#ifdef CONFIG_DETECT_HUNG_TASK
  1079		{
  1080			.procname	= "hung_task_panic",
  1081			.data		= &sysctl_hung_task_panic,
  1082			.maxlen		= sizeof(int),
  1083			.mode		= 0644,
  1084			.proc_handler	= proc_dointvec_minmax,
  1085			.extra1		= &zero,
  1086			.extra2		= &one,
  1087		},
  1088		{
  1089			.procname	= "hung_task_check_count",
  1090			.data		= &sysctl_hung_task_check_count,
  1091			.maxlen		= sizeof(int),
  1092			.mode		= 0644,
  1093			.proc_handler	= proc_dointvec_minmax,
  1094			.extra1		= &zero,
  1095		},
  1096		{
  1097			.procname	= "hung_task_timeout_secs",
  1098			.data		= &sysctl_hung_task_timeout_secs,
  1099			.maxlen		= sizeof(unsigned long),
  1100			.mode		= 0644,
  1101			.proc_handler	= proc_dohung_task_timeout_secs,
  1102			.extra2		= &hung_task_timeout_max,
  1103		},
  1104		{
  1105			.procname	= "hung_task_check_interval_secs",
  1106			.data		= &sysctl_hung_task_check_interval_secs,
  1107			.maxlen		= sizeof(unsigned long),
  1108			.mode		= 0644,
  1109			.proc_handler	= proc_dohung_task_timeout_secs,
  1110			.extra2		= &hung_task_timeout_max,
  1111		},
  1112		{
  1113			.procname	= "hung_task_warnings",
  1114			.data		= &sysctl_hung_task_warnings,
  1115			.maxlen		= sizeof(int),
  1116			.mode		= 0644,
  1117			.proc_handler	= proc_dointvec_minmax,
  1118			.extra1		= &neg_one,
  1119		},
  1120	#endif
  1121	#ifdef CONFIG_RT_MUTEXES
  1122		{
  1123			.procname	= "max_lock_depth",
  1124			.data		= &max_lock_depth,
  1125			.maxlen		= sizeof(int),
  1126			.mode		= 0644,
  1127			.proc_handler	= proc_dointvec,
  1128		},
  1129	#endif
  1130		{
  1131			.procname	= "poweroff_cmd",
  1132			.data		= &poweroff_cmd,
  1133			.maxlen		= POWEROFF_CMD_PATH_LEN,
  1134			.mode		= 0644,
  1135			.proc_handler	= proc_dostring,
  1136		},
  1137	#ifdef CONFIG_KEYS
  1138		{
  1139			.procname	= "keys",
  1140			.mode		= 0555,
  1141			.child		= key_sysctls,
  1142		},
  1143	#endif
  1144	#ifdef CONFIG_PERF_EVENTS
  1145		/*
  1146		 * User-space scripts rely on the existence of this file
  1147		 * as a feature check for perf_events being enabled.
  1148		 *
  1149		 * So it's an ABI, do not remove!
  1150		 */
  1151		{
  1152			.procname	= "perf_event_paranoid",
  1153			.data		= &sysctl_perf_event_paranoid,
  1154			.maxlen		= sizeof(sysctl_perf_event_paranoid),
  1155			.mode		= 0644,
  1156			.proc_handler	= proc_dointvec,
  1157		},
  1158		{
  1159			.procname	= "perf_event_mlock_kb",
  1160			.data		= &sysctl_perf_event_mlock,
  1161			.maxlen		= sizeof(sysctl_perf_event_mlock),
  1162			.mode		= 0644,
  1163			.proc_handler	= proc_dointvec,
  1164		},
  1165		{
  1166			.procname	= "perf_event_max_sample_rate",
  1167			.data		= &sysctl_perf_event_sample_rate,
  1168			.maxlen		= sizeof(sysctl_perf_event_sample_rate),
  1169			.mode		= 0644,
  1170			.proc_handler	= perf_proc_update_handler,
  1171			.extra1		= &one,
  1172		},
  1173		{
  1174			.procname	= "perf_cpu_time_max_percent",
  1175			.data		= &sysctl_perf_cpu_time_max_percent,
  1176			.maxlen		= sizeof(sysctl_perf_cpu_time_max_percent),
  1177			.mode		= 0644,
  1178			.proc_handler	= perf_cpu_time_max_percent_handler,
  1179			.extra1		= &zero,
  1180			.extra2		= &one_hundred,
  1181		},
  1182		{
  1183			.procname	= "perf_event_max_stack",
  1184			.data		= &sysctl_perf_event_max_stack,
  1185			.maxlen		= sizeof(sysctl_perf_event_max_stack),
  1186			.mode		= 0644,
  1187			.proc_handler	= perf_event_max_stack_handler,
  1188			.extra1		= &zero,
  1189			.extra2		= &six_hundred_forty_kb,
  1190		},
  1191		{
  1192			.procname	= "perf_event_max_contexts_per_stack",
  1193			.data		= &sysctl_perf_event_max_contexts_per_stack,
  1194			.maxlen		= sizeof(sysctl_perf_event_max_contexts_per_stack),
  1195			.mode		= 0644,
  1196			.proc_handler	= perf_event_max_stack_handler,
  1197			.extra1		= &zero,
  1198			.extra2		= &one_thousand,
  1199		},
  1200	#endif
  1201		{
  1202			.procname	= "panic_on_warn",
  1203			.data		= &panic_on_warn,
  1204			.maxlen		= sizeof(int),
  1205			.mode		= 0644,
  1206			.proc_handler	= proc_dointvec_minmax,
  1207			.extra1		= &zero,
  1208			.extra2		= &one,
  1209		},
  1210	#if defined(CONFIG_SMP) && defined(CONFIG_NO_HZ_COMMON)
  1211		{
  1212			.procname	= "timer_migration",
  1213			.data		= &sysctl_timer_migration,
  1214			.maxlen		= sizeof(unsigned int),
  1215			.mode		= 0644,
  1216			.proc_handler	= timer_migration_handler,
  1217			.extra1		= &zero,
  1218			.extra2		= &one,
  1219		},
  1220	#endif
  1221	#ifdef CONFIG_BPF_SYSCALL
  1222		{
  1223			.procname	= "unprivileged_bpf_disabled",
  1224			.data		= &sysctl_unprivileged_bpf_disabled,
  1225			.maxlen		= sizeof(sysctl_unprivileged_bpf_disabled),
  1226			.mode		= 0644,
  1227			/* only handle a transition from default "0" to "1" */
  1228			.proc_handler	= proc_dointvec_minmax,
  1229			.extra1		= &one,
  1230			.extra2		= &one,
  1231		},
  1232	#endif
  1233	#if defined(CONFIG_TREE_RCU) || defined(CONFIG_PREEMPT_RCU)
  1234		{
  1235			.procname	= "panic_on_rcu_stall",
  1236			.data		= &sysctl_panic_on_rcu_stall,
  1237			.maxlen		= sizeof(sysctl_panic_on_rcu_stall),
  1238			.mode		= 0644,
  1239			.proc_handler	= proc_dointvec_minmax,
  1240			.extra1		= &zero,
  1241			.extra2		= &one,
  1242		},
  1243	#endif
  1244	#ifdef CONFIG_STACKLEAK_RUNTIME_DISABLE
  1245		{
  1246			.procname	= "stack_erasing",
  1247			.data		= NULL,
  1248			.maxlen		= sizeof(int),
  1249			.mode		= 0600,
  1250			.proc_handler	= stack_erasing_sysctl,
  1251			.extra1		= &zero,
  1252			.extra2		= &one,
  1253		},
  1254	#endif
  1255		{
  1256			.procname       = "cgroup_default_retry",
> 1257			.data           = &sysctl_cgroup_default_retry,
  1258			.maxlen         = sizeof(unsigned int),
  1259			.mode           = 0644,
  1260			.proc_handler   = proc_dointvec_minmax,
> 1261			.extra1         = &sysctl_cgroup_default_retry_min,
> 1262			.extra2         = &sysctl_cgroup_default_retry_max,
  1263		},
  1264		{ }
  1265	};
  1266	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux