Re: [PATCH cgroup/for-4.21 1/2] cpuset: Minor cgroup2 interface updates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 20, 2018 at 07:44:10AM -0800, Tejun Heo wrote:
> Hello, Peter.
> 
> On Tue, Nov 20, 2018 at 01:46:24PM +0100, Peter Zijlstra wrote:
> > Why though? The Changelog doesn't give rationale for the actual changes.
> 
> Ah yeah, sorry about that.
> 
> > And I'm not sure I agree with either one of them.
> > 
> > The partition is a scheduling feature;
> 
> So is everything with cpuset.cpus prefix.  They're all modifying how
> scheduler handles the cpus.

Fair enough I suppose.

> > and I like 0/1 much better to type, so why not allow that?
> 
> Mostly for consistency and it's generally better to keep interfaces
> minimal - e.g. what if we need to add support for more key words to
> the file?  Would we assign incrementing integers to them?

Or just not give them a numeric alias at all.

But numbers are more minimal than words, so lets just get rid of them
pesky word things ;-)

Alternatively; we could use kstrtobool(). That accepts a metric ton of
input ;-)



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux