Hi,
With ext4's data=ordered mode and the underlying blk throttle setting, we
can easily run to hang,
1.
mount /dev/sdc /mnt -odata=ordered
2.
mkdir /sys/fs/cgroup/unified/cg
3.
echo "+io" > /sys/fs/cgroup/unified/cgroup.subtree_control
4.
echo "`cat /sys/block/sdc/dev` wbps=$((1 << 20))" > /sys/fs/cgroup/unified/cg/io.max
5.
echo $$ > /sys/fs/cgroup/unified/cg/cgroup.procs
6.
// background dirtier
xfs_io -f -c "pwrite 0 1G" $M/dummy &
7.
echo $$ > /sys/fs/cgroup/unified/cgroup.procs
8.
// issue synchronous IO
for i in `seq 1 100`;
do
xfs_io -f -s -c "pwrite 0 4k" $M/foo > /dev/null
done
And the hang is like
[jbd2-sdc]
jbd2_journal_commit_transaction
journal_submit_data_buffers
# file 'dummy' has been written by writeback kthread
journal_finish_inode_data_buffers
# wait on page's writeback
Then all the operations of ext4 which need to start journal will have
to wait until journal committing transaction completes.
Since there is no per-memcg throttling, such as dirty ratio or dirty
bytes throttle, balance_dirty_pages() may not be able to slow down the
background dirtier task as expected.
I googled a little bit and found that Greg did the related work[1]
back in 2011, but seems the patch set didn't make it to kernel.
Now that we have writeback aware cgroup, is there any plan to push the
patch set again or are there any alternative solutions/suggestions?
[1]: https://lwn.net/Articles/455341/
thanks,
-liubo
