Hi Matt, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20180309] [also build test WARNING on v4.16-rc6] [cannot apply to v4.16-rc4 v4.16-rc3 v4.16-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Matt-Roper/cgroup-private-data-and-DRM-i915-integration/20180319-071752 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> kernel/cgroup/cgroup.c:94:1: sparse: symbol 'cgroup_idr_lock' was not declared. Should it be static? >> kernel/cgroup/cgroup.c:4655:17: sparse: incorrect type in assignment (different address spaces) @@ expected void **slot @@ got void [noderef] <avoid **slot @@ kernel/cgroup/cgroup.c:4655:17: expected void **slot kernel/cgroup/cgroup.c:4655:17: got void [noderef] <asn:4>** >> kernel/cgroup/cgroup.c:4655:17: sparse: incorrect type in assignment (different address spaces) @@ expected void **slot @@ got void [noderef] <avoid **slot @@ kernel/cgroup/cgroup.c:4655:17: expected void **slot kernel/cgroup/cgroup.c:4655:17: got void [noderef] <asn:4>** >> kernel/cgroup/cgroup.c:4655:17: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] <asn:4>**slot @@ got sn:4>**slot @@ kernel/cgroup/cgroup.c:4655:17: expected void [noderef] <asn:4>**slot kernel/cgroup/cgroup.c:4655:17: got void **slot >> kernel/cgroup/cgroup.c:4655:17: sparse: incorrect type in assignment (different address spaces) @@ expected void **slot @@ got void [noderef] <avoid **slot @@ kernel/cgroup/cgroup.c:4655:17: expected void **slot kernel/cgroup/cgroup.c:4655:17: got void [noderef] <asn:4>** kernel/cgroup/cgroup.c:2648:20: sparse: context imbalance in 'cgroup_procs_write_start' - wrong count at exit kernel/cgroup/cgroup.c:2704:9: sparse: context imbalance in 'cgroup_procs_write_finish' - wrong count at exit kernel/cgroup/cgroup.c:2815:9: sparse: context imbalance in 'cgroup_lock_and_drain_offline' - wrong count at exit kernel/cgroup/cgroup.c:4375:16: sparse: context imbalance in 'cgroup_procs_write' - wrong count at exit kernel/cgroup/cgroup.c:4416:16: sparse: context imbalance in 'cgroup_threads_write' - wrong count at exit Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
