On Thu, Feb 01, 2018 at 08:49:32PM +0000, Chris Wilson wrote:
> Quoting Matt Roper (2018-02-01 19:53:11)
...
> > +struct cgroup *
> > +cgroup_for_driver_process(struct pid *pid)
> > +{
> > + struct task_struct *task = pid_task(pid, PIDTYPE_PID);
> > +
> > + mutex_lock(&cgroup_mutex);
> > + spin_lock_irq(&css_set_lock);
> > + task_cgroup_from_root(task, &cgrp_dfl_root);
> > + spin_unlock_irq(&css_set_lock);
> > + mutex_unlock(&cgroup_mutex);
>
> Gut feeling says use task = get_pid_task(); if (!task) return NULL and
> put_task_struct(task); for safety.
>
> Shouldn't there be a return here?
Woops, looks like I mis-squashed some of my fixes for this patch in to
patch #4 instead. But yeah, get_pid_task() is better in general.
Matt
> > +}
> -Chris
> --
> To unsubscribe from this list: send the line "unsubscribe cgroups" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
