On Fri 12-01-18 00:59:38, Andrey Ryabinin wrote: > On 01/11/2018 07:29 PM, Michal Hocko wrote: [...] > > I do not think so. Consider that this reclaim races with other > > reclaimers. Now you are reclaiming a large chunk so you might end up > > reclaiming more than necessary. SWAP_CLUSTER_MAX would reduce the over > > reclaim to be negligible. > > > > I did consider this. And I think, I already explained that sort of race in previous email. > Whether "Task B" is really a task in cgroup or it's actually a bunch of reclaimers, > doesn't matter. That doesn't change anything. I would _really_ prefer two patches here. The first one removing the hard coded reclaim count. That thing is just dubious at best. If you _really_ think that the higher reclaim target is meaningfull then make it a separate patch. I am not conviced but I will not nack it it either. But it will make our life much easier if my over reclaim concern is right and we will need to revert it. Conceptually those two changes are independent anywa. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
