On Fri, Dec 01, 2017 at 09:41:54AM +0100, Michal Hocko wrote: > On Thu 30-11-17 15:28:23, Roman Gushchin wrote: > > @@ -1229,6 +1252,41 @@ to be accessed repeatedly by other cgroups, it may make sense to use > > POSIX_FADV_DONTNEED to relinquish the ownership of memory areas > > belonging to the affected files to ensure correct memory ownership. > > > > +OOM Killer > > +~~~~~~~~~~ > > + > > +Cgroup v2 memory controller implements a cgroup-aware OOM killer. > > +It means that it treats cgroups as first class OOM entities. > > This should mention groupoom mount option to enable this functionality. > > Other than that looks ok to me > Acked-by: Michal Hocko <mhocko@xxxxxxxx> > -- > Michal Hocko > SUSE Labs >From 1d9c87128897ee7f27f9651d75b80f73985373e8 Mon Sep 17 00:00:00 2001 From: Roman Gushchin <guro@xxxxxx> Date: Fri, 1 Dec 2017 15:34:59 +0000 Subject: [PATCH] mm, oom, docs: document groupoom mount option Add a note that cgroup-aware OOM logic is disabled by default and describe how to enable it. Signed-off-by: Roman Gushchin <guro@xxxxxx> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Cc: Johannes Weiner <hannes@xxxxxxxxxxx> Cc: Michal Hocko <mhocko@xxxxxxxx> Cc: Vladimir Davydov <vdavydov.dev@xxxxxxxxx> Cc: Tejun Heo <tj@xxxxxxxxxx> Cc: kernel-team@xxxxxx Cc: linux-mm@xxxxxxxxx Cc: linux-kernel@xxxxxxxxxxxxxxx --- Documentation/cgroup-v2.txt | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Documentation/cgroup-v2.txt b/Documentation/cgroup-v2.txt index c80a147f94b7..ff8e92db636d 100644 --- a/Documentation/cgroup-v2.txt +++ b/Documentation/cgroup-v2.txt @@ -1049,6 +1049,9 @@ PAGE_SIZE multiple when read back. and will never kill the unkillable task, even if memory.oom_group is set. + If cgroup-aware OOM killer is not enabled, ENOTSUPP error + is returned on attempt to access the file. + memory.events A read-only flat-keyed file which exists on non-root cgroups. The following entries are defined. Unless specified @@ -1258,6 +1261,12 @@ OOM Killer Cgroup v2 memory controller implements a cgroup-aware OOM killer. It means that it treats cgroups as first class OOM entities. +Cgroup-aware OOM logic is turned off by default and requires +passing the "groupoom" option on mounting cgroupfs. It can also +by remounting cgroupfs with the following command:: + + # mount -o remount,groupoom $MOUNT_POINT + Under OOM conditions the memory controller tries to make the best choice of a victim, looking for a memory cgroup with the largest memory footprint, considering leaf cgroups and cgroups with the -- 2.14.3 -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
