[cgroup:review-cgroup-btrfs-metadata 8/8] fs/btrfs/check-integrity.c:2744:10: error: implicit declaration of function 'submit_bh_blkcg_css'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-cgroup-btrfs-metadata
head:   718f5fe07069a8eae4a561eb835be3a3163a6539
commit: 718f5fe07069a8eae4a561eb835be3a3163a6539 [8/8] btrfs: ensure that metadata and flush are issued from the root cgroup
config: blackfin-allyesconfig (attached as .config)
compiler: bfin-uclinux-gcc (GCC) 6.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 718f5fe07069a8eae4a561eb835be3a3163a6539
        # save the attached .config to linux build tree
        make.cross ARCH=blackfin 

All errors (new ones prefixed by >>):

   fs/btrfs/check-integrity.c: In function 'btrfsic_submit_bh':
>> fs/btrfs/check-integrity.c:2744:10: error: implicit declaration of function 'submit_bh_blkcg_css' [-Werror=implicit-function-declaration]
      return submit_bh_blkcg_css(op, op_flags, blkcg_root_css);
             ^~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/submit_bh_blkcg_css +2744 fs/btrfs/check-integrity.c

  2738	
  2739	int btrfsic_submit_bh(int op, int op_flags, struct buffer_head *bh)
  2740	{
  2741		struct btrfsic_dev_state *dev_state;
  2742	
  2743		if (!btrfsic_is_initialized)
> 2744			return submit_bh_blkcg_css(op, op_flags, blkcg_root_css);
  2745	
  2746		mutex_lock(&btrfsic_mutex);
  2747		/* since btrfsic_submit_bh() might also be called before
  2748		 * btrfsic_mount(), this might return NULL */
  2749		dev_state = btrfsic_dev_state_lookup(bh->b_bdev->bd_dev);
  2750	
  2751		/* Only called to write the superblock (incl. FLUSH/FUA) */
  2752		if (NULL != dev_state &&
  2753		    (op == REQ_OP_WRITE) && bh->b_size > 0) {
  2754			u64 dev_bytenr;
  2755	
  2756			dev_bytenr = BTRFS_BDEV_BLOCKSIZE * bh->b_blocknr;
  2757			if (dev_state->state->print_mask &
  2758			    BTRFSIC_PRINT_MASK_SUBMIT_BIO_BH)
  2759				pr_info("submit_bh(op=0x%x,0x%x, blocknr=%llu (bytenr %llu), size=%zu, data=%p, bdev=%p)\n",
  2760				       op, op_flags, (unsigned long long)bh->b_blocknr,
  2761				       dev_bytenr, bh->b_size, bh->b_data, bh->b_bdev);
  2762			btrfsic_process_written_block(dev_state, dev_bytenr,
  2763						      &bh->b_data, 1, NULL,
  2764						      NULL, bh, op_flags);
  2765		} else if (NULL != dev_state && (op_flags & REQ_PREFLUSH)) {
  2766			if (dev_state->state->print_mask &
  2767			    BTRFSIC_PRINT_MASK_SUBMIT_BIO_BH)
  2768				pr_info("submit_bh(op=0x%x,0x%x FLUSH, bdev=%p)\n",
  2769				       op, op_flags, bh->b_bdev);
  2770			if (!dev_state->dummy_block_for_bio_bh_flush.is_iodone) {
  2771				if ((dev_state->state->print_mask &
  2772				     (BTRFSIC_PRINT_MASK_SUBMIT_BIO_BH |
  2773				      BTRFSIC_PRINT_MASK_VERBOSE)))
  2774					pr_info("btrfsic_submit_bh(%s) with FLUSH but dummy block already in use (ignored)!\n",
  2775					       dev_state->name);
  2776			} else {
  2777				struct btrfsic_block *const block =
  2778					&dev_state->dummy_block_for_bio_bh_flush;
  2779	
  2780				block->is_iodone = 0;
  2781				block->never_written = 0;
  2782				block->iodone_w_error = 0;
  2783				block->flush_gen = dev_state->last_flush_gen + 1;
  2784				block->submit_bio_bh_rw = op_flags;
  2785				block->orig_bio_bh_private = bh->b_private;
  2786				block->orig_bio_bh_end_io.bh = bh->b_end_io;
  2787				block->next_in_same_bio = NULL;
  2788				bh->b_private = block;
  2789				bh->b_end_io = btrfsic_bh_end_io;
  2790			}
  2791		}
  2792		mutex_unlock(&btrfsic_mutex);
  2793		return submit_bh(op, op_flags, bh);
  2794	}
  2795	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux