On Wed, Aug 30, 2017 at 01:56:22PM -0700, David Rientjes wrote: > On Wed, 30 Aug 2017, Roman Gushchin wrote: > > > I've spent some time to implement such a version. > > > > It really became shorter and more existing code were reused, > > howewer I've met a couple of serious issues: > > > > 1) Simple summing of per-task oom_score doesn't make sense. > > First, we calculate oom_score per-task, while should sum per-process values, > > or, better, per-mm struct. We can take only threa-group leader's score > > into account, but it's also not 100% accurate. > > And, again, we have a question what to do with per-task oom_score_adj, > > if we don't task the task's oom_score into account. > > > > Using memcg stats still looks to me as a more accurate and consistent > > way of estimating memcg memory footprint. > > > > The patchset is introducing a new methodology for selecting oom victims so > you can define how cgroups are compared vs other cgroups with your own > "badness" calculation. I think your implementation based heavily on anon > and unevictable lrus and unreclaimable slab is fine and you can describe > that detail in the documentation (along with the caveat that it is only > calculated for nodes in the allocation's mempolicy). With > memory.oom_priority, the user has full ability to change that selection. > Process selection heuristics have changed over time themselves, it's not > something that must be backwards compatibile and trying to sum the usage > from each of the cgroup's mm_struct's and respect oom_score_adj is > unnecessarily complex. I agree. So, it looks to me that we're close to an acceptable version, and the only remaining question is the default behavior (when oom_group is not set). Michal suggests to ignore non-oom_group memcgs, and compare tasks with memcgs with oom_group set. This makes the whole thing completely opt-in, but then we probably need another knob (or value) to select between "select memcg, kill biggest task" and "select memcg, kill all tasks". Also, as the whole thing is based on comparison between processes and memcgs, we probably need oom_priority for processes. I'm not necessary against this options, but I do worry about the complexity of resulting interface. In my implementation we always select a victim memcg first (or a task in root memcg), and then kill the biggest task inside. It actually changes the victim selection policy. By doing this we achieve per-memcg fairness, which makes sense in a containerized environment. I believe it's acceptable, but I can also add a cgroup v2 mount option to completely revert to the per-process OOM killer for those users, who for some reasons depend on the existing victim selection policy. Any thoughts/objections? Thanks! Roman -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
