I'm having a go at converting cgroups to use my fs_context stuff, and I've spotted a potential bug in the existing code. In cgroup_do_mount(), there is the following snippet: mutex_lock(&cgroup_mutex); spin_lock_irq(&css_set_lock); cgrp = cset_cgroup_from_root(ns->root_cset, root); spin_unlock_irq(&css_set_lock); mutex_unlock(&cgroup_mutex); nsdentry = kernfs_node_dentry(cgrp->kn, dentry->d_sb); Given that locks must be taken to call cset_cgroup_from_root(), is the value of cgrp trustworthy once the locks are dropped? David -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html