On 05/17/2017 05:36 PM, Tejun Heo wrote: > Hello, Waiman. > > On Mon, May 15, 2017 at 09:34:07AM -0400, Waiman Long wrote: >> The debug cgroup currently resides within cgroup-v1.c and is enabled >> only for v1 cgroup. To enable the debug cgroup also for v2, it >> makes sense to put the code into its own file as it will no longer >> be v1 specific. The only change in this patch is the expansion of >> cgroup_task_count() within the debug_taskcount_read() function. >> >> Signed-off-by: Waiman Long <longman@xxxxxxxxxx> > I don't mind enabling the debug controller for v2 but let's please > hide it behind an unwieldy boot param / controller name so that it's > clear that its interface isn't expected to be stable. > > Thanks. > The controller name is "debug" and so it is obvious what this controller is for. However, the config prompt "Example controller" is indeed vague in meaning. So we can make the prompt more descriptive here. As for the boot param, are you saying something like "cgroup_debug" has to be specified in the command line even if CGROUP_DEBUG config is there for the debug controller to be enabled? I am fine with that if you think it is necessary. Regards, Longman -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
