Re: [PATCH] blk-cgroup: fix wrong unlock order when parse per blkg config

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Mon, Apr 24, 2017 at 06:52:05PM +0800, Joseph Qi wrote:
> From: Joseph Qi <qijiang.qj@xxxxxxxxxxxxxxx>
> 
> In case of error blkg in blkg_conf_prep, we should unlock
> queue->queue_lock first and then rcu, just like blkg_conf_finish.

I get that this is inconsistent but why is this wrong?  If this is for
consistency, can you please explain so in the commit so that people
don't confuse it for an actual bug fix?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux