Hi Tejun, hi all: I applied the patch this morning and I'm happy to confirm you that the warning went away. Thank you! Un saludo, Jesús Rodríguez Acosta -- http://es.linkedin.com/in/jesusrodriguezacosta (+34) 653 79 09 64 IMPORTANTE: Este mensaje de correo está destinado únicamente a la persona o entidad a la cual se dirige y puede contener información privilegiada, confidencial y/o de acceso restringido según la legislación vigente. Si usted no es el destinatario indicado, por la presente queda informado de que cualquier uso, distribución o copia de la comunicación está estrictamente prohibido. Si usted ha recibido esta comunicación por error, por favor, avíseme de inmediato. Gracias. IMPORTANT: This email message is intended only for the use of the individual to whom, or entity to which, it is addressed and may contain information that is privileged, confidential and/or exempt from disclosure under applicable law. If you are NOT the intended recipient, you are hereby notified that any use, dissemination, distribution or copying of the communication is strictly prohibited. If you have received this communication in error, please notify me immediately. Thank you. 2016-12-12 21:48 GMT+00:00 Tejun Heo <tj@xxxxxxxxxx>: > Jesús, > > I applied the following patch to cgroup/for-4.10 and will soon push > out to Linus. I'm pretty sure this is what you saw but can you please > verify that the warning goes away with it applied? > > Thanks a lot for the report. > > ------ 8< ------ > From 89bb3eed858ec2ea36ceae822bbf81f1ef24e80d Mon Sep 17 00:00:00 2001 > From: Tejun Heo <tj@xxxxxxxxxx> > Date: Mon, 12 Dec 2016 16:30:29 -0500 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > When a listening socket associated with a cgroup creates a new > connection, it gets cloned and the reference on the cgroup is > incremented by calling cgroup_get(). Such a socket can be left behind > in an empty cgroup after processes are migrated away from it. As an > empty cgroup may be removed, the socket may end up trying to clone new > sockets while associated with a removed cgroup. > > This doesn't break anything in terms of reference counting; however, > as a precaution, cgroup_get() triggers WARN when it's called on a > removed cgroup, which cgroup_sk_alloc() can trigger spuriously. > > We know this path is legit, open code cgroup_get() in > cgroup_sk_alloc() without the sanity check to avoid spuriously > triggering the warning. > > Reported-by: Jesús Rodríguez Acosta <jesus.rodriguez.acosta@xxxxxxxxx> > Signed-off-by: Tejun Heo <tj@xxxxxxxxxx> > Link: http://lkml.kernel.org/r/CAH=7=un56LL12Meu0j+6+ZRcdsnUHomfDLuq=raC6ZtQEwLqTA@xxxxxxxxxxxxxx > Fixes: d979a39d7242 ("cgroup: duplicate cgroup reference when cloning sockets") > Cc: stable@xxxxxxxxxxxxxxx # v4.5+ > Cc: Johannes Weiner <jweiner@xxxxxx> > --- > kernel/cgroup.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/kernel/cgroup.c b/kernel/cgroup.c > index 85bc9be..7fe26595 100644 > --- a/kernel/cgroup.c > +++ b/kernel/cgroup.c > @@ -6318,9 +6318,13 @@ void cgroup_sk_alloc(struct sock_cgroup_data *skcd) > if (cgroup_sk_alloc_disabled) > return; > > - /* Socket clone path */ > + /* > + * Socket clone path. We open-code cgroup_get() here to avoid the > + * cgroup_is_dead() sanity check as a listening socket left in a > + * dead cgroup can still get cloned for new connections. > + */ > if (skcd->val) { > - cgroup_get(sock_cgroup_ptr(skcd)); > + css_get(&sock_cgroup_ptr(skcd)->self); > return; > } > > -- > 2.9.3 > -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
