Hi Rami, On 11/23/2016 11:46 PM, Rami Rosen wrote: > A minor comment: > >> +/** >> + * __cgroup_bpf_update() - Update the pinned program of a cgroup, and >> + * propagate the change to descendants >> + * @cgrp: The cgroup which descendants to traverse >> + * @parent: The parent of @cgrp, or %NULL if @cgrp is the root >> + * @prog: A new program to pin >> + * @type: Type of pinning operation (ingress/egress) >> + * >> + * Each cgroup has a set of two pointers for bpf programs; one for eBPF >> + * programs it owns, and which is effective for execution. >> + * > You have in the following section twice identical checks, for If @prog > is %NULL". > Shouldn't it be here (in the first case only) "If @prog is not %NULL" > instead "If @prog is %NULL"? Yes, you're right, thanks for spotting. If possible, I would like to not send a v10 just for this one missing word in the comments though, but rather fix that up in a separate patch afterwards. Thanks, Daniel > >> + * If @prog is %NULL, this function attaches a new program to the cgroup and >> + * releases the one that is currently attached, if any. @prog is then made >> + * the effective program of type @type in that cgroup. >> + * >> + * If @prog is %NULL, the currently attached program of type @type is released, >> + * and the effective program of the parent cgroup (if any) is inherited to >> + * @cgrp. >> + * > > > Regard, > Rami Rosen > -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
