Re: [PATCH] mm: memcontrol: remove BUG_ON in uncharge_list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed 08-06-16 15:00:48, roy.qing.li@xxxxxxxxx wrote:
> From: Li RongQing <roy.qing.li@xxxxxxxxx>
> 
> when call uncharge_list, if a page is transparent huge, and not need to
> BUG_ON about non-transparent huge, since nobody should be be seeing the
> page at this stage and this page cannot be raced with a THP split up

Johannes do you remember why you have kept this bug on even after
0a31bc97c80c ("mm: memcontrol: rewrite uncharge API")?

> Signed-off-by: Li RongQing <roy.qing.li@xxxxxxxxx>
> ---
>  mm/memcontrol.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 4d9a215..d7a56f1 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -5457,7 +5457,6 @@ static void uncharge_list(struct list_head *page_list)
>  
>  		if (PageTransHuge(page)) {
>  			nr_pages <<= compound_order(page);
> -			VM_BUG_ON_PAGE(!PageTransHuge(page), page);
>  			nr_huge += nr_pages;
>  		}
>  
> -- 
> 2.1.4

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux