Hello, Ross. On Wed, Dec 23, 2015 at 02:30:40PM -0700, Ross Zwisler wrote: > static int mem_cgroup_can_attach(struct cgroup_taskset *tset) > { > struct cgroup_subsys_state *css; > - struct mem_cgroup *memcg; > + struct mem_cgroup *memcg = NULL; It's one thing to add spurious init to shut up gcc > @@ -4805,7 +4805,7 @@ static int mem_cgroup_can_attach(struct cgroup_taskset *tset) > p = leader; > memcg = mem_cgroup_from_css(css); > } > - if (!p) > + if (!p || !memcg) and to another to add an additional processing on it. Please note which gcc version you were using in the commit description and mark the init with a comment. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html