[cgroup:review-xt_cgroup2 4/5] include/linux/cgroup.h:584:43: warning: 'struct sock' declared inside parameter list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-xt_cgroup2
head:   a2ea5b8e460c458101f96739c6a579b4d8ec325a
commit: a139ca59402a4a18bf85ffb975f1c26943bf5b00 [4/5] sock, cgroup: add sock->sk_cgroup
config: i386-tinyconfig (attached as .config)
reproduce:
        git checkout a139ca59402a4a18bf85ffb975f1c26943bf5b00
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/memcontrol.h:22:0,
                    from include/linux/swap.h:8,
                    from include/linux/suspend.h:4,
                    from arch/x86/kernel/asm-offsets.c:12:
>> include/linux/cgroup.h:584:43: warning: 'struct sock' declared inside parameter list
    static inline void cgroup_sk_alloc(struct sock *sk) {}
                                              ^
   include/linux/cgroup.h:584:43: warning: its scope is only this definition or declaration, which is probably not what you want
   include/linux/cgroup.h:585:42: warning: 'struct sock' declared inside parameter list
    static inline void cgroup_sk_free(struct sock *sk) {}
                                             ^

vim +584 include/linux/cgroup.h

   568					    struct dentry *dentry) { return -EINVAL; }
   569	
   570	static inline void cgroup_fork(struct task_struct *p) {}
   571	static inline int cgroup_can_fork(struct task_struct *p,
   572					  void *ss_priv[CGROUP_CANFORK_COUNT])
   573	{ return 0; }
   574	static inline void cgroup_cancel_fork(struct task_struct *p,
   575					      void *ss_priv[CGROUP_CANFORK_COUNT]) {}
   576	static inline void cgroup_post_fork(struct task_struct *p,
   577					    void *ss_priv[CGROUP_CANFORK_COUNT]) {}
   578	static inline void cgroup_exit(struct task_struct *p) {}
   579	static inline void cgroup_free(struct task_struct *p) {}
   580	
   581	static inline int cgroup_init_early(void) { return 0; }
   582	static inline int cgroup_init(void) { return 0; }
   583	
 > 584	static inline void cgroup_sk_alloc(struct sock *sk) {}
   585	static inline void cgroup_sk_free(struct sock *sk) {}
   586	
   587	#endif /* !CONFIG_CGROUPS */
   588	
   589	#endif /* _LINUX_CGROUP_H */

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux