On Thu 14-05-15 12:35:43, Cyril Hrubis wrote: > Hi! > > --- a/testcases/kernel/controllers/memcg/functional/memcg_function_test.sh > > +++ b/testcases/kernel/controllers/memcg/functional/memcg_function_test.sh > > @@ -158,17 +158,12 @@ testcase_21() > > # Case 22 - 24: Test limit_in_bytes will be aligned to PAGESIZE > > testcase_22() > > { > > - test_limit_in_bytes $((PAGESIZE-1)) $PAGESIZE 0 > > + test_limit_in_bytes $((PAGESIZE-1)) 0 0 > > } > > > > testcase_23() > > { > > - test_limit_in_bytes $((PAGESIZE+1)) $((PAGESIZE*2)) 0 > > -} > > - > > -testcase_24() > > -{ > > - test_limit_in_bytes 1 $PAGESIZE 0 > > + test_limit_in_bytes $((PAGESIZE+1)) $((PAGESIZE)) 0 > > } > > That would fail on older kernels without the patch, woudln't it? Yes it will. I thought those would be using some stable release (I do not have much idea about the release process of ltp...). You are definitely right that a backward compatible way is better. I will cook up a patch later today. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html