Hey, >> > > static struct cftype cgroup_dfl_base_files[]; >> > > +#define for_each_subsys_which(ss_mask, ss, ssid) \ >> > > + for_each_subsys((ss), (ssid)) \ >> > > + if ((ss_mask) & (1 << (ssid))) >> > >> > Maybe using for_each_set_bit() is better? >> > >> > #define for_each_subsys_which(ss_mask, ss, ssid) \ >> > for_each_set_bit(ssid, &(ss_mask), CGROUP_SUBSYS_COUNT) \ >> > if ((ss) = group_subsys[ssid] && false) \ >> > ; \ >> > else >> >> Clever that ;-) > > Thanks. It kinda bothers me that for_each_set_bit() doesn't collapse > to combo of ffs() + clearing bit off of a temp mask when size is const > and <= ulong, which would be quite a bit lighter. Right now it'd be > calling into generic find_first/next_bit() functions unconditionally. > Ah well, it can be optimized later. This macro causes issues with lines like: for_each_subsys_which(ss, ssid, ~cgrp_dfl_root_inhibit_ss_mask) In addition, there are a bunch of cgroup_* functions that use unsigned ints for bitops (cgroup_calc_child_subsys_mask, rebind_subsystems, cgroup_print_ss_mask). Is there a better solution to this problem, or should I just switch back to my naive solution? -- Aleksa Sarai (cyphar) www.cyphar.com -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
