Re: [PATCH] cgroup: remove redundant variable in cgroup_mount()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello, Li.

On Sat, Sep 20, 2014 at 02:49:10PM +0800, Zefan Li wrote:
> Both pinned_sb and new_sb indicate if a new superblock is needed,
> so we can just remove new_sb.
> 
> Note now we must check if kernfs_tryget_sb() returns NULL, because
> when it returns NULL, kernfs_mount() may still re-use an existing
> superblock, which is just allocated by another concurent mount.
> 
> Suggested-by: Tejun Heo <tj@xxxxxxxxxx>
> Signed-off-by: Zefan Li <lizefan@xxxxxxxxxx>

Ah, this is so much better.  Thanks for doing this.  Applied to
cgroup/for-3.18.

> ---
> 
> Hi Tejun,
> 
> I think you wanted to see the @new_sb argument removed from kernfs_mount(),
> but it's also used in debugfs and we can't use kernfs_tryget_sb() to
> replace the new_sb check.

Bummer, someday. :)

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux