Re: [PATCH v2 RESEND] cfq-iosched: Fix wrong children_weight calculation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



(2014/08/27 23:15), Tejun Heo wrote:
> As it looks like the patch needs to be respun anyway.
> 
> On Wed, Aug 27, 2014 at 05:32:32PM +0900, Toshiaki Makita wrote:
>> +	/*
>> +	 * Update leaf_weight.  We cannot update weight at this point
>> +	 * because cfqg might already have been activated by its child.
> 
> Maybe something like the following is better?
> 
>  because cfqg might already have been activated and is contributing
>  its current weight to the parent's child_weight.
> 

Thank you for your comment.
It looks better.
I'll reword it.

Thanks,
Toshiaki Makita
--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux