On Wed 23-07-14 11:06:08, Johannes Weiner wrote: > On Wed, Jul 23, 2014 at 04:38:47PM +0200, Michal Hocko wrote: [...] > > OK, thanks for the clarification. I had this feeling but couldn't wrap > > my head around the indirection of the code. > > > > It seems that checkig PageCgroupUsed(new) and bail out early in > > mem_cgroup_migrate should just work, no? > > If the new page is already charged as page cache, we could just drop > the call to mem_cgroup_migrate() altogether. Yeah, it is just that we do not want to do all the page->page_cgroup->PageCgroupUsed thing in replace_page_cache_page. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
