On Tue 13-05-14 09:16:56, Johannes Weiner wrote: > On Mon, May 12, 2014 at 05:34:58PM +0200, Michal Hocko wrote: [...] > > >From 6f2a33df7750f0794b03f7a85aba02a4e631f2a0 Mon Sep 17 00:00:00 2001 > > From: Michal Hocko <mhocko@xxxxxxx> > > Date: Mon, 12 May 2014 16:20:46 +0200 > > Subject: [PATCH] memcg: deprecate memory.force_empty knob > > > > force_empty has been introduced primarily to drop memory before it gets > > reparented on the group removal. This alone doesn't sound fully > > justified because reparented pages which are not in use can be reclaimed > > also later when there is a memory pressure on the parent level. > > > > Mark the knob CFTYPE_INSANE which tells the cgroup core that it > > shouldn't create the knob with the experimental sane_behavior. Other > > users will get informed about the deprecation and asked to tell us more. > > But I expect that most users will be simply cgroup remove handlers > > which do that since ever without having any good reason for it. > > > > If somebody really cares and the reparented pages, which would be dropped > > otherwise, push out more important ones then we should fix the > > reparenting code and put pages to the tail. > > > > Signed-off-by: Michal Hocko <mhocko@xxxxxxx> > > I'm skeptical the printk will do anything useful, but you marked the > knob insane and that's the most important change. Well, I suspect that most users will try the new semantic at the latest possible moment and then it can come up as a surprise. I would prefer to catch those as soon as possible. I am even thinking to push this to SLES to catch possible enterprise users. > Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx> Thanks. OK, I will post it to Andrew. I guess he will want to have some rate-limiting or print-once semantic... -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
