On Thu, Apr 17, 2014 at 01:53:08PM +0800, Li Zefan wrote: > If we hit the retry path, we'll call parse_cgroupfs_options() again, > but the string we pass to it has been modified by the previous call > to this function. > > This bug can be observed by: > > # mount -t cgroup -o name=foo,cpuset xxx /mnt && umount /mnt && \ > mount -t cgroup -o name=foo,cpuset xxx /mnt > mount: wrong fs type, bad option, bad superblock on xxx, > missing codepage or helper program, or other error > ... > > The second mount passed "name=foo,cpuset" to the parser, and then it > hit the retry path and call the parser again, but this time the string > passed to the parser is "name=foo". > > To fix this, we avoid calling parse_cgroupfs_options() again in this > case. > > Signed-off-by: Li Zefan <lizefan@xxxxxxxxxx> Applied to cgroup/for-3.15-fixes. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
