re: cgroup: convert to kernfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Tejun Heo,

The patch 2bd59d48ebfb: "cgroup: convert to kernfs" from Feb 11,
2014, leads to the following static checker warning:

	kernel/cgroup.c:2442 cgroup_add_cftypes()
	warn: possible memory leak of 'set'

kernel/cgroup.c
  2431  int cgroup_add_cftypes(struct cgroup_subsys *ss, struct cftype *cfts)
  2432  {
  2433          struct cftype_set *set;
  2434          int ret;
  2435  
  2436          set = kzalloc(sizeof(*set), GFP_KERNEL);
  2437          if (!set)
  2438                  return -ENOMEM;
  2439  
  2440          ret = cgroup_init_cftypes(ss, cfts);
  2441          if (ret)

kfree(set);

  2442                  return ret;
  2443  
  2444          cgroup_cfts_prepare();
  2445          set->cfts = cfts;
  2446          list_add_tail(&set->node, &ss->cftsets);
  2447          ret = cgroup_cfts_commit(cfts, true);
  2448          if (ret)
  2449                  cgroup_rm_cftypes(cfts);
  2450          return ret;
  2451  }

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe cgroups" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

  Powered by Linux