Hello, Li. On Wed, Feb 12, 2014 at 02:28:53PM +0800, Li Zefan wrote: > v2: > - Don't call deactivate_super() inside cgroup_mutex, as cgroup_kill_sb() > will be called if sb refcnt reaches 0. I don't think this can happen, > as cgroup_create() is called through vfs, so vfs should guarantee the > superblock won't disappear. Still better not depend on it even my guess > is probably correct. If the deadlock can't actually happen, I don't really care either way as the code goes away after kernfs conversion anyway. I've already applied v1, so if you think this change is important, can you send an incremental patch? Thanks! -- tejun -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html