On Thu, 16 Jan 2014, Johannes Weiner wrote: > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index a815686..b482f49 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -1841,13 +1841,17 @@ static void mem_cgroup_out_of_memory(struct mem_cgroup *memcg, gfp_t gfp_mask, > > break; > > }; > > points = oom_badness(task, memcg, NULL, totalpages); > > - if (points > chosen_points) { > > - if (chosen) > > - put_task_struct(chosen); > > - chosen = task; > > - chosen_points = points; > > - get_task_struct(chosen); > > Where did that GET go? > No idea, good catch! This patch was doomed from the GET-go. -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html